You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Kokkos recently added static asserts to ensure users were not including private header files. This can be a problem when using a tool like clangd, which attempts to "help" by automatically managing includes for you as you use objects. Would it be possible to include the appropriate IWYU pragmas so clangd knows to include e.g. Kokkos_Code.hpp instead of Kokkos_View.hpp. Presumably this could be some sort of find+sed since the private/public headers are already distinguished with the KOKKOS_IMPL_PUBLIC_INCLUDE macro?
The text was updated successfully, but these errors were encountered:
It is something we would be generally interested in doing.
Would you be willing to draft initial support for it plus basic testing? We can see that all headers are properly annotated after this is in place and help wrapping up the PR.
Kokkos recently added static asserts to ensure users were not including private header files. This can be a problem when using a tool like clangd, which attempts to "help" by automatically managing includes for you as you use objects. Would it be possible to include the appropriate IWYU pragmas so clangd knows to include e.g.
Kokkos_Code.hpp
instead ofKokkos_View.hpp
. Presumably this could be some sort offind
+sed
since the private/public headers are already distinguished with theKOKKOS_IMPL_PUBLIC_INCLUDE
macro?The text was updated successfully, but these errors were encountered: