Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient check method is not compatible with the latest PCL #47

Open
jiancong0204 opened this issue Mar 25, 2022 · 0 comments
Open

Gradient check method is not compatible with the latest PCL #47

jiancong0204 opened this issue Mar 25, 2022 · 0 comments

Comments

@jiancong0204
Copy link

Hi Koide,

thank you so much for your great work! However, I just found that the gradient test method you use for gicp's optimization progress is not compatible with that of the official PCL since this commit 3854 They just provided a virtual function, which has to be overridden when implementing, for checking the gradient when using bfgs algorithm.

the corresponding code in your project is here

By writing this issue, I am just wondering if you had plan to modify this project to be compatible with the latest PCL.

Looking forward to your reply and best regards,
Jiancong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant