Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting of mixed content #12

Closed
wants to merge 4 commits into from
Closed

Fix sorting of mixed content #12

wants to merge 4 commits into from

Conversation

DanielRose
Copy link

Fixes #11.

Builds on top of the fixes of @zanaptak

zanaptak and others added 4 commits July 30, 2020 20:23
@zanaptak
Avoid attribute swap during compare. Fixes #9.
c1f54b4
@zanaptak
Handle null attribute list. Fixes #7.
d4d21e1
@zanaptak
Avoid initial reversing of node list. Fixes #4.
981ad09
@DanielRose
Only sort elements with children that can be sorted without breaking …
4e80720 
…something

For many node types (ex. mixed Text and Element), sorting those nodes breaks the content.
Only sort when the children are all Element (or Comment, which might end up in the wrong place, but it shouldn't prevent sorting).
@DanielRose DanielRose closed this by deleting the head repository Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting nodes with mixed content can break the content
2 participants
@DanielRose @zanaptak