Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App: Code Clean up #5948

Merged
merged 57 commits into from
May 29, 2024
Merged

Sample App: Code Clean up #5948

merged 57 commits into from
May 29, 2024

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Apr 24, 2024

fixes #5950
fixes #5943
fixes #5880
fixes #5999

We need to tidy up our sample app code! And because each component might be connected, it will be hard to make edit on different PR. Making this huge PR could make the life much easier.

This includes but not limited to:

  • Making sure all names (like variables and services) are consistent.
  • Checking that all code files are in the right folders.
  • Using the best coding practices.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2024
@knative-prow knative-prow bot requested review from pmbanugo and skonto April 24, 2024 18:23
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e282e5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/665645e3f619ec00089d08fe
😎 Deploy Preview https://deploy-preview-5948--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@Leo6Leo Leo6Leo marked this pull request as ready for review May 27, 2024 13:23
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@knative-prow knative-prow bot requested a review from snneji May 27, 2024 13:23
@Leo6Leo
Copy link
Member Author

Leo6Leo commented May 27, 2024

/cc @pierDipi @Cali0707 @creydr

@pierDipi
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link

knative-prow bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 638cbfb into knative:main May 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants