-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 API Doesn't Respect linode Private Bucket Endpoint After the Upload #1782
Comments
Hi @mustafa519. #669 was closed as the issue couldn't be replicated.
|
Hello @knadh I currently ended up using the public bucket type. Public bucket or providing custom public url works well. However, when I set a private bucket, it uses Then I used aws bucket instead linode, it still didn't work. In Summary:
Those all I can provide as the details. Thank you for the investigation. |
That's very helpful. Sounds like a URL generation issue when type=private. Will investigate this. |
Same setup here. I am using on prem cloudian s3 service. I get exact same behaviour when i set up private bucket. Uploads just fine but generates "amazonaws.com" url. |
hm, when the bucket type is empty AND there is no public URL set (the "Custom Public URL" field in settings), then a pre-signed URL is generated.
Assuming that the S3-compatible private endpoints also support generating signed URLs, the https://github.com/rhnvrm/simples3 lib should ideally support custom URLs. @rhnvrm could you confirm whether setting the |
Yeah https://github.com/rhnvrm/simples3/blob/master/presigned.go#L58-L60 There is also a helper: https://github.com/rhnvrm/simples3/blob/master/simples3.go#L244-L260 |
Version:
Description of the bug and steps to reproduce:
Hello, I am trying to setup listmonk.
I set the linode s3 credentials like below screenshot. Linode object storage endpoint works well, however previewing it is broken. It tries to get the media from AWS s3 endpoint rather than the linode endpoint. It's happening on the campaign add attachment step.
E.g:
https://mybucket.s3.amazonaws.com/folder/thumb_388291.jpg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=RN7IENFKQAG4IU64E7TW%2F20240313%2Feu-central-1%2Fs3%2Faws4_request&X-Amz-Date=20240313T210501Z&X-Amz-Expires=601200&X-Amz-SignedHeaders=host&X-Amz-Signature=dca06ed307f4beacf5da282ab3234d98c746165756fc1084435417bbbcb4e9f7
I am not familiar with the go language, so I couldn't find the broken part of the code.
I hope those information helps!
Edit: Just figured it out, on this issue #669 mentioned the same bug.
Screenshots:
The text was updated successfully, but these errors were encountered: