Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Remove constructor for generated components #118

Open
klemmchr opened this issue Sep 26, 2022 · 2 comments
Open

Remove constructor for generated components #118

klemmchr opened this issue Sep 26, 2022 · 2 comments
Assignees
Labels
type: feature New feature or enhancement
Milestone

Comments

@klemmchr
Copy link
Owner

Description

The default protected constructor prevents the usage of the component generator as described in #117. It should be removed from the code generator.

Code sample

No response

@klemmchr klemmchr added the type: feature New feature or enhancement label Sep 26, 2022
@klemmchr klemmchr added this to the 7.0 milestone Sep 26, 2022
@klemmchr klemmchr self-assigned this Sep 26, 2022
@pm64
Copy link

pm64 commented Oct 9, 2022

Not sure if you want to expand the scope of this issue or create a new one, but the same should be done for protected virtual void Dispose(bool disposing). When inheriting from InputBase, for example, we receive warning CS0114: 'MyComponent.Dispose(bool)' hides inherited member 'InputBase<string>.Dispose(bool)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword..

@klemmchr
Copy link
Owner Author

klemmchr commented Oct 9, 2022

@pm64 I would include that issue in here as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature New feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants