-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider turning off corelibrarydesugaring for this lib #541
Comments
This may be true, but the |
Thoughts on making this library |
I also use this in some projects, and they are all |
FYI: In version 2.6.0, I will remove desugar requirement from the library (while keeping the current min sdk). All the calendar logic live in the There is already a snapshot published with this feature if you'd like to test that everything works as expected: repositories {
google()
mavenCentral()
// Add the snapshot repository
maven("https://s01.oss.sonatype.org/content/repositories/snapshots/")
}
dependencies {
implementation("com.kizitonwose.calendar:view:2.6.0-SNAPSHOT")
implementation("com.kizitonwose.calendar:compose:2.6.0-SNAPSHOT")
} |
Consider turning off core library desugaring:
Calendar/core/build.gradle
Line 18 in 14991af
This forces any app that uses this library to also turn on core library desugaring, which slows down their build.
Most things can be done using the Kotlin standard library and avoiding using JDK apis that require core library desugaring.
If you are open to this, I can look into submitting a PR for this change.
The text was updated successfully, but these errors were encountered: