-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text color get reset every time a message is sent #1777
Comments
It works as expected for me in chrome using latest master. But it can sometimes have strange behaviour. The text input formatting is a total nightmare, I did try to improve it in #1741 but that has issues in firefox and other strange behaviour so needs reworking. I wont be adding the colour to state persistence as I think that is a little too much |
Thanks for your quick reply. I think there's something odd. I'm using a self-hosted instance of KiwiIRC that I deployed 1 week ago by cloning the git repository using this URL: https://github.com/kiwiirc/kiwiirc.git. If I run a git log on the project directory, I can see that the latest commit is f613f32, dated July 16th (so it looks current to me). However, looking at some of the changes made in #1741 (for example, in ControlInput.vue), they don't match the files that I have. Those changes were commited on Feb 25, so if I've cloned the repo a week ago I guess I should have them but I don't. And if I compare the files that are on the repository right now (in the master branch on Github) they don't match that commit either. I guess this can be why this works as expected for you, but it certainly fails when using the KiwiIRC client cloned from the master branch. Perhaps I am doing something wrong, so I'd like to ask a couple of questions related to this.
|
#1741 is not merged due to the issues with firefox and other things its just a pull-request and branch on my fork kiwi.commithash in browser console will tell you what commit your running |
When a user chooses a color for writing, the color gets reset every time he or she sends a message.
Steps to reproduce the behavior:
Expected behavior:
When a users picks a color, that color selection should be persistent until the user chooses a different color or cancels the formatting.
It would be nice if the selected color could also persist between sessions, so that users who like to write using always the same color don't have to choose it every time they open KiwiIRC.
Additional notes:
I've tried to set the text color persistently by making some modifications to TextStyle.vue (so that the selected color gets saved to the settings on the local storage). And I have also modified IrcInput.vue to get the selected color from the saved settings and apply it to new messages.
However, so far I've had partial success with this. On Firefox this seems to work (the selected color persists between messages and sessions). But with Chrome it fails randomly (sometimes the color gets reset to black for no apparent reason).
The text was updated successfully, but these errors were encountered: