Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error page] skipLink variable is missing from Error.tsx #532

Open
giorgoslytos opened this issue Apr 5, 2024 · 1 comment
Open

[Error page] skipLink variable is missing from Error.tsx #532

giorgoslytos opened this issue Apr 5, 2024 · 1 comment

Comments

@giorgoslytos
Copy link
Contributor

This is a minor issue, but there are some cases that it might be useful.
When we navigate, for example to an invalid url and get 404 and the client_id is not provided, in the original keycloak theme there is a variable skipLink which is true in such cases but it is not provided from the kcContext and it is not used in Error.tsx.

As a result baseUrl will be undefined have faulty behavior.

@garronej
Copy link
Collaborator

garronej commented Apr 5, 2024

Hey @giorgoslytos,
Thanks for reporting, this is definatly something that deserve investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants