Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Children of CircularProgressbarWithChildren don't scale #204

Open
ugnelis opened this issue Mar 10, 2022 · 1 comment
Open

Children of CircularProgressbarWithChildren don't scale #204

ugnelis opened this issue Mar 10, 2022 · 1 comment

Comments

@ugnelis
Copy link

ugnelis commented Mar 10, 2022

馃悰 Bug report

Summary of issue

Children of CircularProgressbarWithChildren aren't scaling evenly. Would it be possible to have children assigned to parent SVG?

large

smale

Your environment

  • What browser version were you using? FireFox 97.0.1
  • What version of react-circular-progressbar are you using? 2.0.4
@ugnelis
Copy link
Author

ugnelis commented Mar 15, 2022

https://github.com/kevinsqi/react-circular-progressbar/blob/master/src/CircularProgressbarWithChildren.tsx#L16 should use <foreignObject width="100%" height="100%" xmlns="http://www.w3.org/1999/xhtml"> instead of div. Source: https://stackoverflow.com/a/30921225/2122457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ugnelis