Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Bug in combo_basic: helper_get_subsequences() needs to allow length one subsequences when have_single_word = True #59

Open
bryanj1234 opened this issue Mar 9, 2022 · 0 comments

Comments

@bryanj1234
Copy link

In combo_basic.py, we have

def helper_get_subsequences(s: str) -> List[str]:
    """Helper function to get all subsequences of a string."""
    sequence = s.split()
    if len(sequence) <= 2:
        return []

But this means that length 1 candidate terms subsequences are not included as subsets of length 2 terms, and length 2 terms are not included as supersets of length one terms.
This is not correct when have_single_word == True.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant