Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent polluting the DOM with unknown attributes #302

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Prevent polluting the DOM with unknown attributes #302

wants to merge 2 commits into from

Conversation

kettanaito
Copy link
Owner

Changes

  • Manually filters out semantically invalid attributes from Box, Composition, and other styled components exported by the library. The same approach is used in Emotion, which prunes invalid props by default.

There is no built-in API in styled-components, only an active (?) discussion regarding the matter.

Issues

Release version

  • internal (no release required)
  • patch (bug fixes)
  • minor (backward-compatible changes)
  • major (backward-incompatible, breaking changes)

Contributor's checklist

  • My branch is up-to-date with the latest master
  • I ran yarn verify to see the build and tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: React does not recognize the A prop on a DOM element
1 participant
@kettanaito