Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work for custom added terminals #41

Open
brybalicious opened this issue Jan 15, 2022 · 3 comments
Open

Does not work for custom added terminals #41

brybalicious opened this issue Jan 15, 2022 · 3 comments

Comments

@brybalicious
Copy link

image

@brybalicious
Copy link
Author

Note Git Bash and Powershell 7 Preview were skipped

@brybalicious
Copy link
Author

Managed to manually add the entries to the registry, so unsure why the switch statement/elif blocks fail at some point

@mchobbylong
Copy link

Those entries were skipped because their hidden properties were missing in neither config.json for the Windows Terminal, nor config.json for the script itself. In this case, the if statement to check hidden property never became truthy (since it only checks if the $isHidden variable is an absolute $false).

Kindly have a look at my patch (mchobbylong/wt-context-menu@1f76635) that fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants