Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy gradient agent - no intention to add? #278

Open
jonilaserson opened this issue Jan 2, 2019 · 7 comments
Open

Policy gradient agent - no intention to add? #278

jonilaserson opened this issue Jan 2, 2019 · 7 comments

Comments

@jonilaserson
Copy link

I've noticed that the REINFORCE algorithm (aka policy gradient, without the Q function) is not listed in the list of agents, even the not-yet-implemented ones. I presume this was intentional? How come such a basic building block of RL was left out?

@RaphaelMeudec
Copy link
Contributor

The list hasn't been updated recently, contributions on algorithm implementations are more than welcome!

@piyush01123
Copy link

Hi. I want to take this up. I'll submit a PR once I'm done.
From what I understand, I should create a class at rl/agents and write a test for it at tests/rl/agents. I'll run the tests as per the Contribution guide before submitting PR.

@RaphaelMeudec RaphaelMeudec added this to To do in Contributing Jan 28, 2019
@tbmreza
Copy link

tbmreza commented Apr 30, 2019

It has been months, is this issue closing anytime soon?

@random-user-x
Copy link
Contributor

I have been working lately to add more algorithms to this software. I am currently busy with my thesis and examination. I will begin this work from mid May. Thank you :)

@tbmreza
Copy link

tbmreza commented Apr 30, 2019

@mirraaj Great! If it's not too much, I would really really appreciate it if you make a blog post walking through the process creating it. Translating from equations to implementation has always been a mystical thing to me.

@random-user-x
Copy link
Contributor

@tbmreza Sincere apologies for such a delay. I am back working for keras-rl. I will keep you updated. Look for new algorithms soon. :)

@hrik2001
Copy link

Hi! Any updates so far on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Contributing
  
To do
Development

No branches or pull requests

6 participants