Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: start Keploy server from Typescript-SDK #352

Closed
1 task done
re-Tick opened this issue Mar 3, 2023 · 7 comments · May be fixed by keploy/typescript-sdk#62 or keploy/typescript-sdk#89
Closed
1 task done

[feature]: start Keploy server from Typescript-SDK #352

re-Tick opened this issue Mar 3, 2023 · 7 comments · May be fixed by keploy/typescript-sdk#62 or keploy/typescript-sdk#89
Labels
Enhancement New feature or request GSoC Issues up for GSoC Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Mar 3, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Currently, we need to run Keploy binary and then run our application which is integrated with TS-SDK.

We can run the keploy binary from SDK and we don't have to see that whether the keploy binary is running or not.

Why should this be worked on?

If Keploy binary is not running then, error will be thrown on making API request on the application.
@re-Tick re-Tick added Enhancement New feature or request GSoC Issues up for GSoC labels Mar 3, 2023
@Sonichigo Sonichigo transferred this issue from keploy/typescript-sdk Mar 3, 2023
@Sonichigo Sonichigo added the Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository label Mar 3, 2023
@tanmay-bajaj
Copy link

Hey @re-Tick @Sonichigo, so in this issue we would be basically need to execute a bash command keploy before starting the node server so the user doesn't need to manually start the keploy server. Looking forward for your suggestions

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 9, 2023 •
edited

@Frey0-0 yes you are correct. But we have to start the keploy server from ts-sdk asynchronously along with the user application.

You can make a PR of your changes.

@tanmay-bajaj
Copy link

tanmay-bajaj commented Mar 9, 2023 •
edited

For this issue, I am thinking to use spawn function of the child process library or just use the exec function to execute the command to run the keploy command before starting the app in the record and test mode checked using a basic if condition. How does this solution sound?

This was referenced Mar 9, 2023
Closed
Open
@tanmay-bajaj
Copy link

I have made a PR #62 @re-Tick please check it out :)

@VishalMyla
Copy link

@re-Tick is this issue still open

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 31, 2023

Yes, you can discuss your changes and make your PR.

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash mentioned this issue Apr 4, 2023
Open
@Hermione2408 Hermione2408 mentioned this issue Apr 6, 2023
Open
@charankamarapu
Copy link
Member

Issue is irrelevant as keploy v1 is no more supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request GSoC Issues up for GSoC Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository
Projects
None yet
Milestone
No milestone
5 participants
@Sonichigo @re-Tick @charankamarapu @tanmay-bajaj @VishalMyla