Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Add contributors #53

Open
frinyvonnick opened this issue Jun 17, 2019 · 5 comments
Open

Idea: Add contributors #53

frinyvonnick opened this issue Jun 17, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@frinyvonnick
Copy link

Hi,

First of all, thank you for your awesome work 馃憤

There is a section about author. This would be cool to have a section about contributors too. all-contributors is a specification about recognizing contributors. They also have a tool that edit README.md to add contributors.

@kefranabg kefranabg added enhancement New feature or request good first issue Good for newcomers labels Jun 17, 2019
@kefranabg
Copy link
Owner

Hi @frinyvonnick

Thanks for opening this issue !
I don't know how it could be done exactly yet but I 鉂わ笍the idea.

@kefranabg kefranabg added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jun 17, 2019
Repository owner deleted a comment from engrravijain Jun 28, 2019
@dexterastin
Copy link

dexterastin commented Oct 8, 2019

Hi @kefranabg

I've come up with a good implementation for this idea, may I try this issue? I'm very interested in this project!

@kefranabg
Copy link
Owner

Hi @dexterastin , sure ! Could you first explain what's your implementation idea?

@dexterastin
Copy link

dexterastin commented Oct 10, 2019

@kefranabg
While I was looking for the github API, I found an API that could get the list of contributors in the repository.

It's like this.
https://api.github.com/repos/{user}/{repo}/contributors
ex: https://api.github.com/repos/kefranabg/readme-md-generator/contributors

So I thought maybe I could page this API and get the list and show it to you. The contributors we received includes bot like greenkeeper, but we can check the value of each element's type element and filter it out. I'll get you a pretty good list of contributors if I show you the sort of contributors list.

We've now marked various elements in the contributors section of this repository, but we still don't know how to do anything else, and we can fix the user blog page by calling the api.

@kefranabg
Copy link
Owner

@dexterastin are we ok that this feature is for readme-generator users, not for this repos right? 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants