Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing ALL KPH: Entries #2177

Open
Major-Mike opened this issue Apr 21, 2024 · 11 comments
Open

Showing ALL KPH: Entries #2177

Major-Mike opened this issue Apr 21, 2024 · 11 comments

Comments

@Major-Mike
Copy link

Expected Behavior

When there are KPH: items for a given entry, it should only show those when trying to fill in that site.

Current Behavior

When you have KPH: items for an entry and trying to fill in a site, it shows ALL KPH: items from all entries that have them and not just the one you are trying to fill.

Possible Solution

Whatever current logic is grabbing everything should be adjusted to respect the site the entry is for and currently on only.

Steps to Reproduce (for bugs)

  1. Go to a site that has KPH: items
  2. Try to fill from the attributes list
  3. Observe that ALL items are there

Debug info

KeePassXC - 2.7.7
KeePassXC-Browser - 1.9.0.3
Operating system: Win64 Edition Windows 11 Pro, 22H2, build 22621.3447
Browser: Microsoft Edge 124.0.2478.51 (Official build) (64-bit)

@varjolintu
Copy link
Member

Shows them where exactly?

@Major-Mike
Copy link
Author

In the context menu when you would select what to fill.

@varjolintu
Copy link
Member

Do you mean you want to show Fill Attribute items only for the one you have already filled in the input fields? Got it.
So if none are selected, all attributes are shown in the context menu, but after filling credentials, it's filtered to the selected one?

@Major-Mike
Copy link
Author

No, so let's say you have a site abc.com and you have three attributes called KPH: One, KPH: Two, and KPH: Three. Then you have a site called 123.com and you have two attributes called KPH: One, KPH: Two. When you go to either sites and you right click on the field that needs the value of an attribute and you go to the "attributes" submenu, you will see One, One, Two, Two, Three (all of the attributes from all the entries that have them, even though you filing on site 123.com where only One, Two should appear. Does that clarify?

@varjolintu
Copy link
Member

No, because site 123.com does not have access to site abc.com's entry, unless you using the same entry with both. Even so, you cannot know the attribute value is the same even if the names are identical. And you cannot bind an attribute to a specific site. So this scenario is still a bit unclear to me.

@Major-Mike
Copy link
Author

I was using the example to demonstrate but I am not sure why it is not clear. If attributes are associated to a specific entry for a specific site then it should ONLY appear on that site, period. There is absolutely no reason all the attributes for all entries should show up on the context menu, why would they?

@varjolintu
Copy link
Member

varjolintu commented Apr 23, 2024

The main thing what is unclear to me:
Why attributes of all entries are shown to you because the site only has access to an entry or entries with the specific URL for that site.

If I create two new entries with URLs 123.com and abc.com, and those have different attributes, and then access 123.com, the entry (and its attributes) for abc.com is not shown.

@Major-Mike
Copy link
Author

I believe we are talking about the same thing. That's precisely what I was wondering and why I came here to ask why it would show all that when the expectation is that it would be limited to the entry for the site that you are on.

Now if you have 5 accounts, like say Gmails, and you have attributes for all of them and you are on a page that you need to fill, ok I can get on those how all the 5 entry attributes would show up as the "site" that is bound to them is likely the same, but this wasn't the case for the instance that brought me to you.

So what do you need to do to diagnose this, please tell me, and I can provide it. I am not a novice, so you can pretty much tell me whatever you need and I should be able to give it to you. If I still need to then I will let you know and seek input on how.

@varjolintu
Copy link
Member

At first you should take a look at the entries Properties tab when you edit them. It lists the permissions (KeePassXC-Browser Settings) for the extension. Have you remembered the site permissions earlier, or do you actually get a promp where it asks for them?

Also Browser Integration's Advanced settings tab would be interesting to see. If nothing else helps.

@Major-Mike
Copy link
Author

Sorry for the delay I was out of town for work. The first part I don't quite get but the second part here you go:

image

@varjolintu
Copy link
Member

Just edit your (problematic) entries, and go to the Properties tab where a Plugin Data table is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants