-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when passing wrong value to node
- AttributeError: ‘int’ object has no attribute ‘split’
#2733
Comments
It's easy if the value is
|
I looked through the implementation and noted that the following:
The reason of getting an Given the above my suggestion is adding missing validation at the
but not on
which seems fine, because it will be validated at the Any thoughts? 🙂 |
Please see the suggestion here: main...feature/2733-validate-node-values |
@ElenaKhaustova nice analysis, I think if we can validate at node level, we should do this as we can give better error message. Please go ahead and open a PR, I think people may have some comment on the error message, but this looks good enough to me. |
Description
Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
Node is suppose to take name of datasets (or parmaeters), when users put a value in node, they get an obscure error.
See full traceback:
Context
Why is this change important to you? How would you use it? How can it benefit other users?
The error is common for beginner. It would be great that if the error message can suggest the fix immediately.
Possible Implementation
(Optional) Suggest an idea for implementing the addition or change.
Raise a KedroError instead of AttributeError
Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.
Improve the logic how
dataset
is reference, insert validating logic. The error is now coming from pipeline/pipeline.py:33_transcode_split
, which doesn't seem to be the right place to raise error.The text was updated successfully, but these errors were encountered: