Do not check if macOS uses an Intel CPU #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix @MWin123! I'm wondering if we can also make the error message a bit clearer for the general case where a user has tried to install kcctl onto an unsupported environment? Thinking something like this: if OS.linux? && Hardware::CPU.intel?
url "https://github.com/kcctl/kcctl/releases/download/v1.0.0.Alpha5/kcctl-1.0.0.Alpha5-l>
sha256 "669006978af4599da25221fbeaabf6cd956061238a3a1ab452435f0b574d16a8"
elsif OS.mac?
url "https://github.com/kcctl/kcctl/releases/download/v1.0.0.Alpha5/kcctl-1.0.0.Alpha5-o>
sha256 "562e59dd6890567492eb4f43a2dc64c45caf78d7f7794039a1a179c0e7af9fbb"
else
raise RuntimeError.new("kcctl is only supported on Linux (with Intel CPU) or MacOS")
end |
|
Thanks @C0urante, the custom error message is definitely a good addition. Feel free to submit your own PR to replace this one. I just changed one line anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes kcctl/kcctl#134.
See also kcctl/kcctl#245. Although SDKMAN! requires an additional fix.