Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Fritz Backed up Wake on LAN via CLI #148

Open
samba2 opened this issue Feb 12, 2022 · 8 comments · May be fixed by #195
Open

Support Fritz Backed up Wake on LAN via CLI #148

samba2 opened this issue Feb 12, 2022 · 8 comments · May be fixed by #195

Comments

@samba2
Copy link

samba2 commented Feb 12, 2022

WOL only works on layer 2. In a mixed fixed/ wireless LAN environment, there can be situations where e.g. your home NAS is attached to the LAN port and in case you need it, you want to wake it up from your wifi connected notebook.

Fritz TR-064 exposes this feature and it would be handy to have it also available at the CLI.
@samba2 samba2 mentioned this issue Feb 12, 2022
Open
@samba2
Copy link
Author

samba2 commented Feb 12, 2022 •
edited

addressed by #149

@mib1185
Copy link
Contributor

mib1185 commented Feb 12, 2022

addressed by #150

i guess you mean #149 😉

@samba2
Copy link
Author

samba2 commented Feb 12, 2022

addressed by #150

i guess you mean #149 😉

Yes, just found out about my mess - sorry for the confusion.

@kbr
Copy link
Owner

kbr commented Jul 17, 2022

Made some initial comments to the pull request.

@samba2
Copy link
Author

samba2 commented Jul 17, 2022

@kbr tnx for the input and the suggestions. Will try to respond during the next days.

@chrisbraucker
Copy link

Hi! I saw that the related PR has been open for about a year now, with no further input from the original author. I just implemented the WOL API method in my fork in fritzhosts.py before I saw this issue/PR, in order to add it to the library interface.
I would like to see this feature and optionally the CLI addition through to get merged.

@kbr I don't want to trespass on @samba2's prior work without their permission but would like to offer my help, do you have a suggestion on how to continue working on this? I'd be up to refactor the CLI code according to your requests, or can write my own implementation instead.

@samba2
Copy link
Author

samba2 commented Sep 10, 2023

@chrisbraucker tnx for picking up on that. Feel free to improve/ alter/ copy/ bin my suggested changes

@samba2 samba2 closed this as completed Sep 10, 2023
@samba2 samba2 reopened this Sep 10, 2023
@kbr
Copy link
Owner

kbr commented Sep 10, 2023

@chrisbraucker In the next couple of weeks I'm short in time to go into this. But it seems you got confirmation from @samba2 to go ahead. I appreciate this kind of friendly communication very much and hope to join again as soon as possible.

@chrisbraucker chrisbraucker linked a pull request Sep 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add WoL CLI with convenience features chrisbraucker/fritzconnection
4 participants
@kbr @samba2 @chrisbraucker @mib1185