-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public access to MQTT client functions #176
Comments
Fair point. The method should be public. I will change that.
It's up to the plugin implementer which connection to use, but the service connection should definitely be usable by the plugin. That is the reason why I made it available.
The plugin has its own lifecycle, that's independent of this tool. Thus, please keep the plugin in your own repo. I can link it in the readme file if you want. |
Hello!
I am writing a simple plugin to publish all values to Home Assistant.
Currently I am using the MQTT client from
DeyePluginContext.mqtt_client
. Unfortunately, the client does not have a public function to publish a message to MQTT.Therefore, I am currently “abusing” the protected function
__do_publish()
:I prefer to use the existing connection. What do you think about adding public functions for publishing and subscribing to the
DeyeMqttClient
class? Or do you prefer to instantiate a separate MQTT client for the plugin?Would you exclude a PR to integrate the plugin into your repo or do you prefer adding it to your own repo?
Kind regards,
Carsten
The text was updated successfully, but these errors were encountered: