-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement virtualization for list views #125
Comments
Could I work on this, Mas? |
Yes, of course. Thanks for the initiative! Please go ahead. Don't forget to submit a Draft Pull Request soon to signal other contributors that you have started working on it. 😉 |
Hi mas @zainfathoni, I am having a difficulty while trying to make a draft PR (pic attached). What I have done:
Nothing works for me. Also, I have no problem push/pull to another repo. Would you help me with that? :sungkem: |
Hi Mas @suliskh, you can't push directly to this repository, because you don't have write permission to this repository. You can read more about Forking Projects here. @andriawan could you please assist him if he has any further issues? |
Oke mas @zainfathoni .. Please mention me if you have any issue with this mas @suliskh |
FYI mas @suliskh |
after forking this repo, you will have copy of this repo on your account. you can start push branch on your copy of repo. github will inform you about PR for this original/upstream repo cc @suliskh |
Halo mas @zainfathoni and mas @andriawan, thank you for guiding me and I've managed to make a PR(#134) with some caveat that I can't fix. Would you mind looking into that? Please see the "Caveat" section. Thank you :sungkem: |
Description
In provinces with a large number of contacts, the item rendering was delayed while scrolling due to a large number of HTML elements that need to be rendered by the browser.
WhatsApp.Video.2021-07-18.at.10.10.43.mp4
Expected Behaviour
There should be no blank screen rendered while scrolling the items.
If this is implemented correctly, the Lighthouse scores should have been much better than this:
Additional Information
We can use
react-window
to implement the virtualization technique in the list.The text was updated successfully, but these errors were encountered: