Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Implement alternative file change strategy #6

Open
Vorror opened this issue Feb 4, 2017 · 6 comments
Open

Feature : Implement alternative file change strategy #6

Vorror opened this issue Feb 4, 2017 · 6 comments

Comments

@Vorror
Copy link

Vorror commented Feb 4, 2017

Add ability to detect source code changes in ways other than system events(Helps IDEs such as goland).
See original issue kataras/iris#598

@ghost
Copy link

ghost commented Feb 4, 2017

You convinced me, mostly, with your kindness, I'm starting to code it!

ghost pushed a commit that referenced this issue Feb 5, 2017
@ghost ghost added the enhancement label Feb 5, 2017
@ghost
Copy link

ghost commented Feb 5, 2017

@Vorror Done,

Could you please upgrade your iris with go get -u github.com/kataras/iris and execute:
iris run main.go and confirm that is working well for your IDE?

More: https://github.com/kataras/rizla/blob/master/HISTORY.md

@Vorror
Copy link
Author

Vorror commented Feb 5, 2017

Hmm, I don't think so. Also texted Sublime, and TextEdit(They stopped working also).

@ghost
Copy link

ghost commented Feb 5, 2017

Can you try go get -u github.com/kataras/rizla and do rizla -walk main.go on the gogland and in sublime and if sublime with -walk doesn't works could you check without -walk and tell me the results please, because on my machine they seem to be working?

@Vorror
Copy link
Author

Vorror commented Feb 5, 2017

Sure!
Results:

Using -Walk Platform Auto-Reloads
No Sublime Yes
Yes Sublime No
No Gogland Yes
Yes Gogland No

Actually weirdly enough gogland does work without -walk(using latest build)
screen shot 2017-02-05 at 12 06 46 pm

So I'm not even sure we should continue

@ghost
Copy link

ghost commented Feb 5, 2017

So we will remove the -flag from iris and we should be fine. rizla's default watcher is working fine.

Thanks for your detailed answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant