Does not work with expo

[prameetc]

I tried to use the example project code in my project and not able to see the "See More" and "See Less" option, am I doing something wrong?

[fliklab]

I am using this plugin in two RN projects. It works fine in one app. But it doesn't work well in another app as your screenshot. Both codes are almost identical and I can't find the reason why it dosen' t work. The difference is the react-native version. The working project is version 0.62, what doesn't work is 0.61.5.

(edited) I've seen it work well a while ago, but now I'm seeing that both aren't working correctly.

[1ike]

Cuz dependency react-native-text-size does not work as I understood. I think we can forget about these packages. :(

[kashishgrover]

Hey guys, I’ve been pretty busy over the past couple of months. I will release an update for this very soon, and update the docs with my latest findings as well. Apologies for the delay

[kashishgrover]

@prameetc @fliklab @1ike I just pushed v1.2.0 to npm. Can you folks try it out and give feedback? I'll keep this issue open till we solve this for good. Thanks!

[1ike]

Still have the error "Cannot read property 'measure' of undefined". It was predictable cuz "react-native-text-size" still in use.
"react-native-text-size" may be has problem with Expo (Expo 36 in my case).

[kashishgrover]

@1ike In my knowledge, there is no package like react-native-text-size that can work for expo. Since that package links natively, it won't work with an expo managed workflow. You will have to eject the project or use a barebones react native project for that.
To calculate the width of a text, we need to use this package. If you find any alternative which will help us get rid of this dependency, do suggest. All we need to do here is accurately calculate the width of the text.

[1ike]

It will be usefull to write in Readme about this.

[kashishgrover]

You're right, I'll do that. Thanks!

[fliklab]

Thank you for updates! It is now working well. @kashishgrover

And I found something different from before:
If there is a line break in the text, it works to break the text right there and display 'see more'.
Previously, there was a case where 'see more' was not displayed when there was a line break, so it seems to be an improvement. However, it seems not intended when there is a line-break in a position less than the max-number of lines, 'see more' is displayed from there.

[kashishgrover]

@fliklab Thanks for testing it. I’m glad it is better now.
Regarding the line break thing, it was something I added as per my use case in my project. There could be edge cases remaining. Feel free to make another issue on this repo with some screenshots of the text before and after clicking “see more” and we can have a discussion over there.

[mehdinourollah]

I'm having this issue ( not showing the Show More and Show less) but in React Native CLI and not expo
"react": "16.13.1", "react-native": "0.63.4", "react-native-text-size": "^4.0.0-rc.1", "react-native-see-more-inline": "^1.3.0",

[kashishgrover]

@mehdinourollah can you verify if the react-native-text-size package got installed correctly? It should have a folder in your project's node_modules folder.

react-native-see-more-inline/src/SeeMore/SeeMoreUtil.js

Line 33 in cbcffb2

const { width: totalTextWidth } = await reactNativeTextSize.measure({

[mehdinourollah]

Sorry It's working with react-native-text-size now ...It needed a clean android and starting over to react-native-text-size install it's native modules...Thank you so much for this great plugin bro

[vbylen]

Has anybody tried if this library works now with expo dev-client?

[dryprogrammer]

I'm still getting this error. aMarCruz/react-native-text-size#39 was supposed to fix the native linking

[dryprogrammer]

https://github.com/benjaminharringtonrose/react-native-text-dimensions/blob/master/react-native.config.js approach also seems to work with react-native.config.js

[dryprogrammer]

I just used https://www.npmjs.com/package/@duonghaidang/react-native-text-more for now