Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ID on Windows 10 Mingw64 #7

Open
DDRBoxman opened this issue Sep 2, 2017 · 2 comments
Open

Report ID on Windows 10 Mingw64 #7

DDRBoxman opened this issue Sep 2, 2017 · 2 comments

Comments

@DDRBoxman
Copy link

I'm playing around with an elgato streamdeck on windows and I had to remove the report ID to get it to work. Not sure if an underlying library is acting differently or what.

https://github.com/karalabe/hid/blob/master/hid_enabled.go#L168

@benma
Copy link

benma commented Aug 2, 2018

@karalabe I also had to work around the library appending a report ID on windows only.

I understand that you do it for windows only as on unix, the signal11 library strips it off again (if the first byte is zero).

This is an issue if you send message that happens to start with a zero byte.

In my code, I had to make sure to add a report ID for unix, but not for windows.

I suggest that you add the report ID also for unix. Backwards compatibility would be an issue, though there are various ways to cope with this.

Thoughts?

@benma
Copy link

benma commented Aug 31, 2018

Ping @karalabe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants