Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors due to escaped special chars #47

Open
corentinbettiol opened this issue Nov 3, 2021 · 0 comments
Open

Errors due to escaped special chars #47

corentinbettiol opened this issue Nov 3, 2021 · 0 comments
Labels
bug Something isn't working feedback needed

Comments

@corentinbettiol
Copy link
Member

Say you have this keyword:

that's awesome

Then your meta keywords will maybe contain this:

that's awesome

But your html content will contain this:

[...] and that's awesome!

Django check seo does not unescape content in keywords or in meta description (and that's cool because there can be a XSS). However, for websites who escapes specials chars in meta keywords/description tags, maybe we could use a list of authorized chars in the settings, and unescape only the keywords/description tags, like this:

DJANGO_CHECK_SEO_UNESCAPE_AUTHORIZED_CHARS = ["'", "\"", "!", "and", "so", "on", "..."]

I don't really know what to do regarding this issue for now. Its way simpler to just fix the escaping in keywords & description tags.

@corentinbettiol corentinbettiol added bug Something isn't working feedback needed labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback needed
Projects
None yet
Development

No branches or pull requests

1 participant