-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent results in case of LEFT OUTER JOIN, GROUP BY and HAVING #1107
Comments
I noticed something similar to this. When I had duplicate results within my query, the This seemed to be because of this: kaminari/kaminari-activerecord/lib/kaminari/activerecord/active_record_relation_methods.rb Lines 24 to 25 in 325fc07
Which would early exit if @yuki24 @tumayun I think was was introduced by: #932 |
Was working on Rails 5.1
Stop working on Rails 5.2+
Key difference:
on 5.1 was used extra
DISTINCT id
query and passed exact IDs to queryon 5.2 used LIMIT + OFFSET
It works wrong on dataset with LEFT OUTER JOIN. See details below
I am challenging Rails v5.2.8.1, but future versions broken as well.
Following test suite reproduces my issue for different Rails versions
The text was updated successfully, but these errors were encountered: