Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement request: set op.Handle as point to FileHandle/DirHandle #788

Open
rockeet opened this issue Jan 13, 2024 · 0 comments
Open

Improvement request: set op.Handle as point to FileHandle/DirHandle #788

rockeet opened this issue Jan 13, 2024 · 0 comments

Comments

@rockeet
Copy link

rockeet commented Jan 13, 2024

Now op.Handle is fuseops.HandleID which needs map HandleID to FileHandle by fs.fileHandles ro by fs.dirHandles to DirHandle.

If set op.Handle(uint64) as pointer to FileHandle or DirHandle, the map can be omitted, especially the lock for accessing fs.fileHandles and fs.dirHandles can be omitted, especially for frequently Read and Write, the mutex lock is racing and expensive.

The fuse kernel protocol provides handle is for userspace to relate kernel object and userspace object, set it as a pointer is the most efficient way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant