Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility warnings #15

Open
queenvictoria opened this issue Jun 26, 2019 · 2 comments
Open

Accessibility warnings #15

queenvictoria opened this issue Jun 26, 2019 · 2 comments

Comments

@queenvictoria
Copy link

I intend to come back to this issue and submit a pull request if I have time.

I see that there is an outstanding issue for this in the upstream library
dimsemenov/PhotoSwipe#1503

We have the opportunity in this addon to fix this. The code is pretty straight forward. Within the empty button we include something like

          <span class="sr-only" aria-hidden="true">Close slideshow</span>

And then in css

.sr-only { display: none; }

As I say--I'll circle back to this if I get time.

@queenvictoria
Copy link
Author

queenvictoria commented Jun 26, 2019

Also we probably need to support alt tags too.
dimsemenov/PhotoSwipe#1423

@queenvictoria
Copy link
Author

Instead of the sr-only <span> we can do this:

<button aria-label="Next"></button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant