Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all wallet specific helpers to @kadena/wallet #812

Open
2 of 3 tasks
javadkh2 opened this issue Aug 23, 2023 · 2 comments
Open
2 of 3 tasks

Move all wallet specific helpers to @kadena/wallet #812

javadkh2 opened this issue Aug 23, 2023 · 2 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@javadkh2
Copy link
Collaborator

Please confirm the following:

Is your feature request related to a problem?

@kadena/wallet could be a place for all wallet specific helpers
I believe we also need to think about the api, since wallets have some features like connect,get accounts and etc...
we had a related discussion here
#750

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Do you have any additional context?

No response

Participation

  • I am willing to submit a pull request for this feature request.
@javadkh2 javadkh2 added the enhancement New feature or request label Aug 23, 2023
@javadkh2 javadkh2 changed the title Move all wallet specific helpers to @kadena/wallet and think about improving the API. Move all wallet specific helpers to @kadena/wallet Aug 23, 2023
@ash-vd
Copy link
Contributor

ash-vd commented Aug 31, 2023

I suggest we use @kadena/wallet-adapters as a name. With wallet people could get the idea that the contents are for wallet builders. It is also in line with others in the space, such as MetaMask and Solana

@github-actions
Copy link
Contributor

This issue is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants