Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the need for remove_xkeys patch #548

Open
burmanm opened this issue Jun 30, 2023 · 0 comments
Open

Investigate the need for remove_xkeys patch #548

burmanm opened this issue Jun 30, 2023 · 0 comments
Labels
assess Issues in the state 'assess' enhancement New feature or request

Comments

@burmanm
Copy link
Contributor

burmanm commented Jun 30, 2023

What is missing?

There have been changes to the x-kubernetes-list-map-keys and x-kubernetes-list-type generation in the controller-runtime since 0.10.0 (as well as changes in the Kubernetes).

Investigate if there's anymore need and if the preserveUnknownFields is in in the correct place for the json.RawMessage.

Why is this needed?

We only remove half of the xkeys, from properties, but not from the claims. That's not consistent.
@burmanm burmanm added the enhancement New feature or request label Jun 30, 2023
@adejanovski adejanovski added the assess Issues in the state 'assess' label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assess Issues in the state 'assess' enhancement New feature or request
Projects
K8ssandra
Status: Assess/Investigate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burmanm @adejanovski