Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Top-K sampling for improved user control #1110

Merged

Conversation

VaibhavMalik4187
Copy link
Contributor

📑 Description

This commit adds Top-K sampling, a feature that allows users to control the randomness of the generated text by specifying the number of most probable next words considered by the model. This enhances user control and potentially improves the quality of the generated outputs.

Closes #1105

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VaibhavMalik4187 VaibhavMalik4187 requested review from a team as code owners May 11, 2024 06:14
This commit adds Top-K sampling, a feature that allows users to control
the randomness of the generated text by specifying the number of most
probable next words considered by the model. This enhances user control
and potentially improves the quality of the generated outputs.

Fixes: k8sgpt-ai#1105

Signed-off-by: VaibhavMalik4187 <[email protected]>
@VaibhavMalik4187 VaibhavMalik4187 changed the title feat: introduce the Top K parameter in AI configs feat: implement Top-K sampling for improved user control May 11, 2024
@VaibhavMalik4187
Copy link
Contributor Author

VaibhavMalik4187 commented May 12, 2024

@JuHyung-Son, @AlexsJones could you please take a look? Thanks!

Copy link
Contributor

@anders-swanson anders-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @VaibhavMalik4187

@AlexsJones AlexsJones merged commit eda5231 into k8sgpt-ai:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Top K as a backend parameter
3 participants