-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
about pitch coherence #33
Comments
I've checked the code in the function compute_band_corr didn't apply sqrt I'm not sure about which Exp[i] value should I take 0 or 1 in case of exception that Ex[i] or Ep[i] is 0. wait for your suggestion thanks. |
sorry,I confused the two functions. void compute_band_energy(float *bandE, const kiss_fft_cpx *X) { |
hello,
In your code:
Exp[i] = Exp[i]/sqrt(1e-15+Ex[i]*Ep[i]).
while bandE[i]=sqrt(sum[i]) in the function compute_band_corr.
I think the code should be
if(Ex[i]*Ep[i]==0)
Exp[i] = 0;(or 1?)
else
Exp[i] = Exp[i]/(1e-15+Ex[i]*Ep[i]).
And this can only make pitch coherence{Exp[i]} be 1,when signal{X} and it's periodic component {P} are exactly the same。
The text was updated successfully, but these errors were encountered: