-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify in documentation how input width/height and output width/height correlate #51
Comments
This is correct. It seemed obvious to me but I guess it's not. I'll try to add some clarification in the next release. Thanks for sharing this. |
Thanks @mhulse for your very helpful explanation, this was indeed not obvious at all, and this is the only place where I found some clarification. However it's still not completely clear: does that mean that the From experimenting it seems that the |
Hello,
From the README:
In terms of documentation and the above example, I think it would be nice to have a little explanation as to why the output's width/height values (200x200) are larger than the desired input's width/hieght (100x100 values).
Here's an example of desired input widths and heights and smartcrop's output widths and heights:
I guess it just took me some exploration time to discover the correlation between the input and output dimensions. Clearly, and correct me if I am wrong, smartcrop is saying:
With that said, one issue I am running into is that the output numbers are not exact (as you can see above); maybe it should also be mentioned in the docs that if one wants an exact crop, they will have to account for rounding errors and use something like ImageMagick's
^
:The text was updated successfully, but these errors were encountered: