urlencode is applied to Issue/PR title

[boesing]

Hey there,

I've released v2.0.0 of laminas/laminas-httphandlerrunner and realized, that urlencode is applied to the title of a PR and Issue.

Actually, the titles are used as a descriptive link-text and thus, should not be encoded because they're not part of the URL itself.

17: feature: Add additional headers_sent informations to the EmitterException [...]

I've had a quick view over the source code but could not directly find the corresponding lines. Will have a deeper dive somewhen in the future and will create an bugfix if not done by any other consumer already.

[boesing]

Okay, I've found the corresponding lines:

changelog-generator/src/ChangelogGenerator/IssueFactory.php

Line 35 in cd4d35e

$title = str_replace(['[', ']', '_'], ['[', ']', '_'], $title);

Is there any specific reason why the title needs to get replaced like this?

[WyriHaximus]

Seems to be introduced in #29 to resolve #27

[boesing]

I guess this was made to avoid having markdown conflicts.
Maybe a more complex regular expression should be applied first while replacing the corresponding matches rather than the whole title?
What do you think?

[WyriHaximus]

@boesing That should do the trick, and probably also use a dataprovider for that changed tests and toss several scenarios at it.