Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter preview persistence #283

Open
mathiaszinnen opened this issue Dec 9, 2020 · 5 comments
Open

Adapter preview persistence #283

mathiaszinnen opened this issue Dec 9, 2020 · 5 comments
Assignees

Comments

@mathiaszinnen
Copy link
Contributor

Currently all imported data is persisted in the adapter, even if the result is returned directly and not a reference to the persisted data.
I suggest we adapt the /preview and /preview/raw endpoints so that data is always included there and never persisted.
Another possibility would be to move the persistence to the stateful datasource package altogether and never persist anything in the adapter package like proposed in #267 .
Any opinions @georg-schwarz , @lunedis , @sonallux ?

@mathiaszinnen mathiaszinnen added this to To do in ODS Development Dec 9, 2020
@georg-schwarz
Copy link
Member

I like the second idea. We only need to persist data that is part of the internal flows, so it should be part of the datasource domain instead of the stateless adapter domain.

@lunedis
Copy link
Contributor

lunedis commented Dec 9, 2020

How does this issue relate to #135 ?

It seems like we should discuss a refactoring and/or redesign of the adapter/datasource service.

@georg-schwarz
Copy link
Member

georg-schwarz commented Dec 9, 2020

Resembles the last bullet point of #135.
I think this issue #283 is the first step to complete the refactoring in #135 afterwards for better paths to the imports.

@mathiaszinnen
Copy link
Contributor Author

It seems like we should discuss a refactoring and/or redesign of the adapter/datasource service.

Agreed, I think both issues are closely related and it probably makes sense to handle both doing a major refactoring..

@georg-schwarz
Copy link
Member

Duplicate of #267 btw if we handle it like this.

@mathiaszinnen mathiaszinnen self-assigned this Dec 9, 2020
@mathiaszinnen mathiaszinnen moved this from To do to In progress in ODS Development Dec 9, 2020
@georg-schwarz georg-schwarz moved this from In progress to Done in ODS Development Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants