Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yada.swagger-parameters & yada.parameters are almost the same code. #315

Open
boxxxie opened this issue May 12, 2020 · 1 comment
Open

Comments

@boxxxie
Copy link
Contributor

boxxxie commented May 12, 2020

i'm confused as to why the swagger one exists, and why it's the default param coercer in yada.

@boxxxie
Copy link
Contributor Author

boxxxie commented May 13, 2020

so, when i swap out yada.swagger-parameters with yada.parameters my backend just breaks. even with minimal schema (map of 1 key and 1 value, no custom types).

I think that it may be worth while to focus on 1 of these files, and get rid of the other. both files look like they have a bit of room for removing complexity, and adding flexibility/optimization.

like, with the swagger file, i can add multimethods for ring-swagger, and get coercers working without modifying the files, but my coercers are at the lowest priority. also there isn't a single default coercer map, there are 3 or 4 or 5 of them in different files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant