-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening custom document in text editor erases document #216
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Thanks for reporting @agupta01 The upcoming 3.6.0 (3.6.0rc0 is released) has seen lots of improvements on the RTC side (:warning: some API has changed - see the migration guide). That said (and putting aside the blank state that is definitely a bug) opening the same file with two different shared models is for now dangerous or at least unstable. The trouble is that you will end up having two different in-memory models that do not interact except if they see the file changes on disk. cc @hbcarlos that could provide more info. |
Description
When using the shared document example and opening the document using the standard text editor ("Editor"), the window is blank. Then, when reopening the file using the extension editor, it throws a JSON parse error indicating the file is now blank.
Reproduce
documents
exampletestfiles/test.example
file to confirm it is not empty.testfiles
, and thentest.example
to open it using the example widget. Confirm you can see a blue box with the text "Hello YJS!"test.example
to open the context menu, then click on "Open With" > "Editor" to open it in the standard text editor. Notice how the opened widget does not show anything.test.example
by double-clicking on it to use the example widgettest.example
file in a non-jupyter viewer. You will see that it is now blank.See the below video for full reproduction:
Screen.Recording.2023-01-23.at.4.39.24.PM.mov
It looks like there is a ServerApp log that is produced right after the text editor is opened that saves test.example (see logs for more context):
Perhaps this call is erroneous and the reason why the file is being cleared when the text editor is opened?
Expected behavior
When the file is opened using the standard text editor, it should display the following:
Context
Note: All paths sanitized with $USER where applicable
Troubleshoot Output
GitHub said this was too long, so here's the pastebin: https://pastebin.com/EFFL90R2Command Line Output
Pastebin: https://pastebin.com/nfV0ppVVBrowser Output
The text was updated successfully, but these errors were encountered: