Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on CI to compare more files #120

Open
jtpio opened this issue Sep 15, 2020 · 0 comments
Open

Add check on CI to compare more files #120

jtpio opened this issue Sep 15, 2020 · 0 comments
Assignees

Comments

@jtpio
Copy link
Member

jtpio commented Sep 15, 2020

Follow-up to #119

Starting from JupyterLab 3.0 extensions can now be installed via pip, which is the way described in these examples.

New files have been added to each example, such as setup.py, MANIFEST.in and pyproject.toml:

https://github.com/jupyterlab/extension-examples/tree/ab5aefa454408b5cc6155c89eed8cc4db641c564/basics/hello-world

One way to check they are all in sync would be to run the upgrade script as mentioned in #119 (comment)

Similar to this step:

- name: Check config files
run: |
diff basics/hello-world/tsconfig.json ${EXAMPLE_FOLDER}/tsconfig.json
diff basics/hello-world/.eslintignore ${EXAMPLE_FOLDER}/.eslintignore
diff basics/hello-world/.eslintrc.js ${EXAMPLE_FOLDER}/.eslintrc.js
diff basics/hello-world/.gitignore ${EXAMPLE_FOLDER}/.gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants