Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to restart a service #264

Open
MarcSkovMadsen opened this issue Apr 6, 2021 · 5 comments · May be fixed by #395
Open

Allow users to restart a service #264

MarcSkovMadsen opened this issue Apr 6, 2021 · 5 comments · May be fixed by #395

Comments

@MarcSkovMadsen
Copy link

I am and will be enabling users to run Bokeh, Dash, Flask, Panel, Streamlit and Voila apps on Jupyter Hub and Binder.

Those apps are a part of the explorative environment and users would expect to be able to update the underlying code and experience the updated apps. In my case the users might not even update the code them selves but the app code would be updated by other users/ a system team in one or more shared folders that are mounted.

Currently I don't see any way of restarting those services. I would like a feature to easily restart a service.

Additional Context

Examples of servers are

I have a similar request for jupyter-panel-proxy that it should provide functionality to restart. But I also created a feature request here as I believe the use case and request is more general. See holoviz/jupyter-panel-proxy#14

@welcome
Copy link

welcome bot commented Apr 6, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics
Copy link
Member

manics commented Apr 6, 2021

Would this PR cover your needs? #215

@bollwyvl
Copy link
Collaborator

I think dedicated restarting/status/logging is worth pursuing. Over on jupyter(lab)-lsp, we've had similar concerns, especially for language servers that have file-based configurations someone may wish to update interactively.... or that get wedged, and need hard restarts.

While we previously had a dependency on jupyter-server-proxy, we ended up needing more bells and whistles, and have been handling our own stuff for a while. We have a stoppable server session concept... but haven't actually ended up exposing it to users.

Perhaps we could consider some way of bringing some parts of the codebase back together, as a common upstream dependency, for example:

  • in python
    • service status/stop handlers
    • logging handlers
  • in (retro)lab
    • a streaming/filtered log viewer
      • text in xtermjs
      • structured logs in datagrid
    • "Running" UIs (with stop, etc)

ideally, these wouldn't specify how the processes actually work: we're using a mishmash of stuff (especially on windows), and might end up having to do some more with e.g. anyio

@manics
Copy link
Member

manics commented Dec 16, 2021

@bollwyvl Do you reckon we should close #215 and start afresh with your above suggestion?

@bollwyvl
Copy link
Collaborator

bollwyvl commented Dec 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants