Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name displayed in the repo providers dropdown list is GitLab.com even if GitLab hostname is overridden #1835

Open
billux opened this issue Mar 13, 2024 · 1 comment
Labels

Comments

@billux
Copy link

billux commented Mar 13, 2024

Bug description

Thanks to this PR, we can use other GitLab instances as repo provider by overriding the hostname attribute in the GitLabRepoProvider class.

Unfortunately, the name displayed in the BinderHub dropdown list of possible repository providers still mentions GitLab.com, which is very misleading for users.

I guess we just have to make the display_name attribute configurable too, but I'm unsure how I should use traitlets object in the Jinja template then.
It seems to be a really easy fix and would be happy to send you a PR to fix that.

@billux billux added the bug label Mar 13, 2024
@billux billux changed the title name displayed in the repo providers dropdown list is _GitLab.com_ even if GitLab hostname is overridden name displayed in the repo providers dropdown list is GitLab.com even if GitLab hostname is overridden Mar 13, 2024
@dlamoris
Copy link

a similar thing happens if github repo provider host is overridden - if the user pastes in the url instead of just user/repo, it will fail to launch since it doesn't remove the host first (on mybinder.org it'll remove github.com)
The only way right now may be to override the template to take out the instruction that pasting url is ok, but would be nice if the js can account for any url host configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants