-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git_crendetials not used in GitRepoProvider #1834
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Ran into this issue last week too. Indeed the issue is as @billux described: the git ls-remote tries to resolve the git reference and doesn't use the credentials at this stage (it does use them after spawning the repo2docker container so the git clone of a private repo works). Investigating a fix, but as a workaround, you can provide the full (40 character) SHA and bypass the git ls-remote. |
Bug description
When using GitRepoProvider, the
git_credentials
are not used to fetch remote git ref before spawning repo2docker.How to reproduce
values.yaml
to set git a valid username/token, according to these instructions for the credentials format:When I try to clone a public git repository (to go behond that error), I do see my credentials passed to the builder pod, so I guess my config is correct:
I'm pretty sure the bug lies in the GitRepoProvider class, where
get_resolved_ref()
here doesn't use thegit_credentials
at all, whereas other classes such as GitLabRepoProvider do use it (like here) to build the git URL.Someone also reported the same problem years ago on this Discourse thread.
The text was updated successfully, but these errors were encountered: