securityContext duplicated in binderhub/helm-chart/binderhub/templates/container-builder/daemonset.yaml

[rgaiacs]

securityContext is declared at

binderhub/helm-chart/binderhub/templates/container-builder/daemonset.yaml

Line 62 in 7b6d423

securityContext:

and

binderhub/helm-chart/binderhub/templates/container-builder/daemonset.yaml

Line 80 in 7b6d423

securityContext:

Should we remove the first occurence?

[sgaist]

Hi,

No, it's on purpose. Each security context applies to the corresponding builder. In this case, you can see that the Podman builder has an additional requirement which might change in the future and does not concern the Docker builder. It's better to have that field tailored to the container definition rather than making it generic for all.
This can of course change in a future revision if all builders make use of the same security context.

Best regards