Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically bump k3s latest version in watch-dependencies #1685

Open
manics opened this issue May 1, 2023 · 1 comment
Open

Automatically bump k3s latest version in watch-dependencies #1685

manics opened this issue May 1, 2023 · 1 comment

Comments

@manics
Copy link
Member

manics commented May 1, 2023

Proposed change

In #1684 I replaced the K3s latest version with 1.26 to reduce the time spent investigating failures related to new versions of k3s. If we automatically update the k3s version in the watch-dependencies workflow we could go further and pin the full 1.26.x version.

Alternative options

Bump the latest k3s version manually

Who would use this feature?

CI maintainers

(Optional): Suggest a solution

Since it's not possible to use a workflow environment variable in a matrix the latest k3s version needs to be updated in multiple places. It might be helpful to add a marker comment to make parsing easier, e.g.
- v1.26 # <<k3s-latest-managed-by-watch-dependencies

@consideRatio
Copy link
Member

consideRatio commented May 22, 2023

I think I'd rather have stable k3s version referenced than having:

  • a hardcoded version bumped manually (k3s 1.26 as now)
  • adding and maintaining automation to bump the hardcoded version

Before we had both latest and stable, but I think we should stick to stable because then we avoid an intermittent k3s related failure where their release artifacts aren't yet published.

The most recent failure was a failire in binderhub depending on z2jh 2, that isn't compatible with k8s 1.27 - because z2jh 2's user-scheduler isn't compatible with k8s 1.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants