New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract annotations into its separate package #126

Open

martinRenou opened this issue Apr 24, 2023 · 1 comment · May be fixed by jupyter-server/jupyter_ydoc#172

Assignees

Labels

Collaborator

martinRenou commented Apr 24, 2023

We currently have annotations (comments) implementation into JupyterCAD https://github.com/QuantStack/jupytercad/tree/main/src/annotation. This should be moved into another package so that it can be reused in other extensions (Notebook, GlueLab etc). A potential place to put this could be https://github.com/jupyterlab/jupyter_collaboration

martinRenou added the enhancement label

Collaborator Author

martinRenou commented Apr 25, 2023

After internal discussions, we agreed that https://github.com/jupyterlab/jupyter_collaboration would be the right place for this.

martinRenou assigned trungleduc

trungleduc assigned hbcarlos and unassigned trungleduc

hbcarlos linked a pull request

that will close this issue

Adds annotations jupyter-server/jupyter_ydoc#172

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment