Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I hope i can perform code completions like Rstudio #995

Open
li1311139481 opened this issue Oct 7, 2023 · 5 comments
Open

I hope i can perform code completions like Rstudio #995

li1311139481 opened this issue Oct 7, 2023 · 5 comments
Labels
feature:completion lang:r r-languageserver, Rlang, etc.
Milestone

Comments

@li1311139481
Copy link

Elevator Pitch

as.you can see. when i use R kernel in jupyterlab. i get a completions like this. There's nothing wrong with that, but sometimes when we do this multiple times, I'd rather not see the previous object. For example, when I type rawdata@assays@ and press tab, I just want to see data, not rawdata@assays@ again.
Perhaps this is an unreasonable request, please apologize. But I really want to implement this feature.
image

Motivation

Too much information will affect the speed at which I can acquire information.

Design Ideas

@krassowski
Copy link
Member

This is very reasonable, thank you for opening this isse!

Implementation-wise, this completion appears to be coming from the R kernel, not from LSP. We need to improve how kernels provide completions because right now we are essentially guessing which parts are prefixes and which parts to show.

@krassowski krassowski added the lang:r r-languageserver, Rlang, etc. label Oct 7, 2023
@li1311139481
Copy link
Author

Thanks for your reply.
BTW, I found something similar happened when I entered the path in quotes. This really affects our choices because we can only see part of the information.
It may not be within the purview of the lsp, but it's similar. Where should I go to ask this question?
image

@krassowski
Copy link
Member

This is an LSP extension issue. What version of the extension and jupyterlab do you use?

@li1311139481
Copy link
Author

jupyterlab version is 4.0.6 installed from pip
jupyterlab-lsp version is 5.0.0rc1 installed from pip

@krassowski krassowski added this to the 5.0.x milestone Oct 7, 2023
@krassowski
Copy link
Member

Thank you! I will look into it first thing after releasing 5.0 (which is in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:completion lang:r r-languageserver, Rlang, etc.
Projects
None yet
Development

No branches or pull requests

2 participants