Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate copy of labextension assets #992

Open
bollwyvl opened this issue Oct 3, 2023 · 0 comments
Open

Avoid duplicate copy of labextension assets #992

bollwyvl opened this issue Oct 3, 2023 · 0 comments

Comments

@bollwyvl
Copy link
Collaborator

bollwyvl commented Oct 3, 2023

Elevator Pitch

Remove one of the copies of the labextension assets from the as-distributed wheels.

The current setup ships two copies of the labextension(s) in the wheel:

  • once in data-files
  • once in src/labextension
    • this is basically never needs to be used, other than during an interactive jupyter labextension develop

Motivation

This slows down the install by being larger on disk (.whl doesn't actually compress very much), and takes more space on disk.

Design Ideas

  • in paths.py and __init__.py
    • during develop, we should be able to detect whether assets exist in the source layout
      • e.g. python_packages/... and core
    • otherwise, always source the assets from the standard data locations
      • whichever is found first (by user preference) in e.g.
      • [jupyter_core.get_data_dir(), *jupyter_paths.jupyter_path()]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant