Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Autocomplete in JupyterLab Real-Time Collaboration (RTC) Environment #1033

Open
avneeshn opened this issue Jan 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@avneeshn
Copy link

avneeshn commented Jan 7, 2024

Background

Hello
We are trying to build an SQL editor client for our users in the form of a JupyterLab extension. We are using jupyterlab-lsp to provide editing capabilities inside notebook cells (P.S. thank you for the amazing work your team is doing, your extension is super helpful!).

Question

I wanted to ask about the autocomplete capability provided by LSP.

We are using @joe-re/sql-language-server as a language-server running in the background. We wanted to provide autocomplete capability to our users inside JupyterLab (RTC)[https://github.com/jupyterlab/jupyter-collaboration] environment. However, there are two cases which make the problem peculiar:

  1. We want different users to be able to use the same notebook (but different cells) and receive autocomplete suggestions at the same time.
  2. We want those users to be able to connect to different SQL engines (I believe sql-language-server has support for multiple data connections + it provides a way to shift between those connections) so that different users get separate autocomplete suggestions at the same time.

Since jupyterlab-lsp provides the autocomplete capability by communicating with language-server, I was wondering is such a solution possible in JupyterLab's RTC environment?

Further, do you know if such a solution is possible if we directly communicate with the sql-language-server (skipping the jupyterlab-lsp layer)?

Thanks a lot in advance. Your help will be greatly appreciated!

@krassowski
Copy link
Member

Yes, this might be possible in the future, but not out of the box now. In the single jupyter-server RTC scenario (a) each user could connect to a new LSP server instance and (b) each user could modify the settings. Both (a) and (b) would need to be implemented, with (b) possibly being a feature of jupyter-collaboration.

Further, do you know if such a solution is possible if we directly communicate with the sql-language-server (skipping the jupyterlab-lsp layer)?

Possibly, but it will come with its own headaches.

@krassowski krassowski added the enhancement New feature or request label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants