Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UView instead of SwiftyOnboardPage #8

Open
ghost opened this issue Apr 21, 2017 · 2 comments
Open

Use UView instead of SwiftyOnboardPage #8

ghost opened this issue Apr 21, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 21, 2017

SwiftyOnboardDataSourceprotocol have the method swiftyOnboardPageForIndexreturning a SwiftyOnboardPage.

This is a huge limitation to SwiftyOnboard customisation. Please consider returning UIView instead of SwiftyOnboardPage .

@juanpablofernandez
Copy link
Owner

This is so there can be a quick setup with preset items in the view. I do understand the limitations behind this, and I'm working on a solution, it's not as easy as returning a UIView (This would remove the preset items, therefore removing the default layout).

@MockinMan
Copy link

Not sure what is the point of default layout when this library is basically useless because of static constraints and views it has for SwiftyOnboardPage. I didn't expect to have such constraints on customisation and basically spent time for nothing.

At least put a big red warning at the top "This Library Works With Only One Default Layout", so people don't waste their time, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants