Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftyOnboardOverlayForPosition never being called #24

Open
Malenea opened this issue Dec 20, 2017 · 1 comment
Open

swiftyOnboardOverlayForPosition never being called #24

Malenea opened this issue Dec 20, 2017 · 1 comment

Comments

@Malenea
Copy link

Malenea commented Dec 20, 2017

Hello, I tried following the examples, it worked well for the CustomPage, everything shows as expected, unfortunately it's not working for the CustomOverlay... Don't know why... I can modify the elements (i.e the buttons) programmatically but it seems to never update itself.

func swiftyOnboardOverlayForPosition(_ swiftyOnboard: SwiftyOnboard, overlay: SwiftyOnboardOverlay, for position: Double) {
        print("====> test <====")
        let overlay = overlay as! CustomOverlay
        let currentPage = round(position)
        overlay.pageControl.currentPage = Int(currentPage)
        overlay.buttonContinue.tag = Int(position)
        if currentPage == 0.0 || currentPage == 1.0 {
            overlay.buttonContinue.isHidden = true
        } else {
            overlay.buttonContinue.isHidden = false
            overlay.buttonContinue.setTitle("Get Started!", for: .normal)
        }
    }

Test is never printed. And using default overlay gets the controlPage updated but not the buttons.

@spaquet
Copy link

spaquet commented Jan 19, 2019

Same issue, but only for the index 0.
For all the other pages (index > 0) the changes are applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants